Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DWPF-1477 Migrate CI pipeline to GitHub Actions #479

Merged
merged 15 commits into from
Mar 26, 2024
Merged

DWPF-1477 Migrate CI pipeline to GitHub Actions #479

merged 15 commits into from
Mar 26, 2024

Conversation

0RWilliams
Copy link
Contributor

No description provided.

@0RWilliams 0RWilliams force-pushed the DWPF-1477 branch 4 times, most recently from d8d45ef to e37f1b9 Compare March 19, 2024 11:21
SamDudley
SamDudley reviewed Mar 20, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@CamLamb
Copy link
Contributor

CamLamb commented Mar 20, 2024

The main branch has changed quite a bit since this.
Please can you pull in those changes and make sure the changes we made to Circle CI are reflected in this PR

SamDudley
SamDudley reviewed Mar 21, 2024
View reviewed changes
.env.ci Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@SamDudley SamDudley changed the title WIP DWPF-1477 DWPF-1477 Migrate CI pipeline to GitHub Actions Mar 26, 2024
@SamDudley SamDudley marked this pull request as ready for review March 26, 2024 11:49
@SamDudley SamDudley requested a review from a team as a code owner March 26, 2024 11:49
@SamDudley SamDudley requested a review from CamLamb March 26, 2024 11:50
CamLamb
CamLamb approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@CamLamb CamLamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small question

makefile Outdated Show resolved Hide resolved
@SamDudley SamDudley merged commit 317b142 into main Mar 26, 2024
1 of 2 checks passed
@SamDudley SamDudley deleted the DWPF-1477 branch March 26, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamDudley SamDudley SamDudley left review comments

@CamLamb CamLamb CamLamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0RWilliams @CamLamb @SamDudley